Fix typehint for WandbLogger's log_model argument
#18458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h should be the earliest point at which the error occurrs. Also removes config.yaml at the end of the test and changes to a temporary directory for each test.
…is the only accepted string value.
|
I added a test that fails before the bug fix and clears afterwards. I assume it should contain some kind of mock.patch for WandB, because that's included in the other WandbLogger tests. But I don't understand enough about this to know what to patch in where. @awaelchli You seem to have worked on several commits of test_wandb.py, could you help with that? I'm also not sure if the test should be moved somewhere else, but I guess that's something that can be looked at during the final review. |
awaelchli
added
logger: wandb
awaelchli
changed the title
log_model argument
awaelchli
requested review from
awaelchli,
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
for more information, see https://pre-commit.ci
Borda
approved these changes
Sep 4, 2023
Borda
approved these changes
Sep 4, 2023
awaelchli
approved these changes
Sep 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18458 +/- ##
==========================================
- Coverage 85% 50% -34%
==========================================
Files 427 419 -8
Lines 33263 33131 -132
==========================================
- Hits 28119 16601 -11518
- Misses 5144 16530 +11386 |
carmocca
approved these changes
Sep 5, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda
pushed a commit
that referenced
this pull request
Sep 12, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: awaelchli <aedu.waelchli@gmail.com> (cherry picked from commit bff2e42)
lantiga
pushed a commit
that referenced
this pull request
Sep 14, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: awaelchli <aedu.waelchli@gmail.com> (cherry picked from commit bff2e42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18370
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18458.org.readthedocs.build/en/18458/