-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid warning about logging interval for fast dev run #18550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
September 14, 2023 00:05
awaelchli
added
bug
Something isn't working
logging
Related to the `LoggerConnector` and `log()`
trainer: fit
and removed
pl
Generic label for PyTorch Lightning package
labels
Sep 14, 2023
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18550 +/- ##
==========================================
- Coverage 85% 50% -35%
==========================================
Files 427 419 -8
Lines 33376 33230 -146
==========================================
- Hits 28342 16730 -11612
- Misses 5034 16500 +11466 |
carmocca
approved these changes
Sep 14, 2023
Borda
approved these changes
Sep 14, 2023
Borda
pushed a commit
that referenced
this pull request
Sep 14, 2023
(cherry picked from commit 670b490)
lantiga
pushed a commit
that referenced
this pull request
Sep 14, 2023
(cherry picked from commit 670b490)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
logging
Related to the `LoggerConnector` and `log()`
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
trainer: fit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the following warning call in case you are running with fast-dev-run:
Noticed in #18545 by @adamjstewart
📚 Documentation preview 📚: https://pytorch-lightning--18550.org.readthedocs.build/en/18550/
cc @Borda @carmocca @Blaizzy @justusschock @awaelchli