Add @override for files in src/lightning/pytorch/loops
#18966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorPrins
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18966 +/- ##
=========================================
- Coverage 70% 48% -22%
=========================================
Files 450 442 -8
Lines 36234 36117 -117
=========================================
- Hits 25286 17379 -7907
- Misses 10948 18738 +7790 |
carmocca
approved these changes
Nov 8, 2023
awaelchli
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds the
@overridedecorator for all files insrc/lightning/pytorch/loops(#18695).📚 Documentation preview 📚: https://pytorch-lightning--18966.org.readthedocs.build/en/18966/