-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the "our" word duplication in the docs #19055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamim
requested review from
williamFalcon,
lantiga,
awaelchli,
carmocca,
edenlightning and
Borda
as code owners
November 23, 2023 00:32
github-actions
bot
added
docs
Documentation related
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
labels
Nov 23, 2023
awaelchli
reviewed
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending the PR 🎉
Jamim
force-pushed
the
fix/word-duplication
branch
from
November 23, 2023 04:52
e874aae
to
988b595
Compare
Borda
approved these changes
Nov 23, 2023
awaelchli
approved these changes
Nov 23, 2023
Jamim
force-pushed
the
fix/word-duplication
branch
6 times, most recently
from
November 27, 2023 20:52
92eef55
to
473c65a
Compare
There were a bit inconsistent sentences with a word duplication issue in the documentation. These changes also: * unify references to the Compatibility matrix * add a reference to the Compatibility matrix into PyTorch Lightning's Installation Docs
Jamim
force-pushed
the
fix/word-duplication
branch
from
November 29, 2023 05:19
473c65a
to
718005c
Compare
lantiga
approved these changes
Dec 1, 2023
Borda
pushed a commit
that referenced
this pull request
Dec 19, 2023
There were a bit inconsistent sentences with a word duplication issue in the documentation. These changes also: * unify references to the Compatibility matrix * add a reference to the Compatibility matrix into PyTorch Lightning's Installation Docs (cherry picked from commit c5363af)
lantiga
pushed a commit
that referenced
this pull request
Dec 20, 2023
There were a bit inconsistent sentences with a word duplication issue in the documentation. These changes also: * unify references to the Compatibility matrix * add a reference to the Compatibility matrix into PyTorch Lightning's Installation Docs (cherry picked from commit c5363af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are a bit inconsistent sentences with a word duplication issue in the documentation, so this PR:
into PyTorch Lightning's Installation Docs
Before submitting
[kinda]
Did you make sure your PR does only one thing, instead of bundling different changes together?PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19055.org.readthedocs.build/en/19055/