Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "our" word duplication in the docs #19055

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Nov 23, 2023

What does this PR do?

There are a bit inconsistent sentences with a word duplication issue in the documentation, so this PR:

Before submitting
  • Did you read the contributor guideline, Pull Request section?
  • [kinda] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19055.org.readthedocs.build/en/19055/

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Nov 23, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the PR 🎉

docs/source-pytorch/starter/installation.rst Outdated Show resolved Hide resolved
@awaelchli awaelchli added the community This PR is from the community label Nov 23, 2023
@Jamim Jamim force-pushed the fix/word-duplication branch from e874aae to 988b595 Compare November 23, 2023 04:52
@Jamim Jamim requested a review from awaelchli November 23, 2023 05:04
@awaelchli awaelchli added this to the 2.2 milestone Nov 23, 2023
@mergify mergify bot added the ready PRs ready to be merged label Nov 23, 2023
@Jamim Jamim force-pushed the fix/word-duplication branch 6 times, most recently from 92eef55 to 473c65a Compare November 27, 2023 20:52
There were a bit inconsistent sentences with
a word duplication issue in the documentation.

These changes also:
  * unify references to the Compatibility matrix
  * add a reference to the Compatibility matrix
    into PyTorch Lightning's Installation Docs
@Jamim Jamim force-pushed the fix/word-duplication branch from 473c65a to 718005c Compare November 29, 2023 05:19
@lantiga lantiga merged commit c5363af into Lightning-AI:master Dec 1, 2023
22 checks passed
@Jamim Jamim deleted the fix/word-duplication branch December 2, 2023 21:12
Borda pushed a commit that referenced this pull request Dec 19, 2023
There were a bit inconsistent sentences with
a word duplication issue in the documentation.

These changes also:
  * unify references to the Compatibility matrix
  * add a reference to the Compatibility matrix
    into PyTorch Lightning's Installation Docs

(cherry picked from commit c5363af)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
There were a bit inconsistent sentences with
a word duplication issue in the documentation.

These changes also:
  * unify references to the Compatibility matrix
  * add a reference to the Compatibility matrix
    into PyTorch Lightning's Installation Docs

(cherry picked from commit c5363af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants