Skip to content

Add @override for remaining files in src/lightning/pytorch #19065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VictorPrins
Copy link
Contributor

@VictorPrins VictorPrins commented Nov 25, 2023

It adds the @override decorator for all files in src/lightning/pytorch (#18695).

As per #18695 (comment), this excludes files in src/lightning/pytorch/utilities and src/lightning/pytorch/demos.

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 25, 2023
@VictorPrins VictorPrins changed the title add override decorator Add @override for remaining files in src/lightning/pytorch Nov 25, 2023
@VictorPrins
Copy link
Contributor Author

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #19065 (70a1c5f) into master (af852ff) will decrease coverage by 33%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19065      +/-   ##
==========================================
- Coverage      82%      49%     -33%     
==========================================
  Files         443      435       -8     
  Lines       36573    36425     -148     
==========================================
- Hits        29811    17822   -11989     
- Misses       6762    18603   +11841     

@awaelchli awaelchli added code quality community This PR is from the community labels Nov 25, 2023
@awaelchli awaelchli added this to the 2.2 milestone Nov 25, 2023
@mergify mergify bot added the ready PRs ready to be merged label Nov 27, 2023
@carmocca carmocca merged commit 37081c1 into Lightning-AI:master Nov 27, 2023
@VictorPrins VictorPrins deleted the feature/#18695_pytorch_remaining branch November 27, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants