[WIP] Enable mmap in torch.load()
#19087
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19087 +/- ##
==========================================
- Coverage 83% 54% -29%
==========================================
Files 443 438 -5
Lines 36613 36519 -94
==========================================
- Hits 30509 19712 -10797
- Misses 6104 16807 +10703 |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 78fa3af | tests/tests_app/utilities/test_login.py | View secret |
| - | Base64 Basic Authentication | 78fa3af | tests/tests_app/utilities/test_login.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
What does this PR do?
WIP
There is a hint in the PyTorch code base that
mmap=Truecould become the default in the future:https://github.com/pytorch/pytorch/blob/f93ea143097716dac0bf1a7c3d89b6a6e3a4e1d0/torch/serialization.py#L989-L991
📚 Documentation preview 📚: https://pytorch-lightning--19087.org.readthedocs.build/en/19087/