Skip to content

Add @override for files in src/lightning/fabric/utilities #19293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

VictorPrins
Copy link
Contributor

@VictorPrins VictorPrins commented Jan 16, 2024

This PR adds the @override decorator for all files in src/lightning/fabric/utilities (#18695).


📚 Documentation preview 📚: https://pytorch-lightning--19293.org.readthedocs.build/en/19293/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jan 16, 2024
Copy link

gitguardian bot commented Jan 16, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 78fa3af tests/tests_app/utilities/test_login.py View secret
- Base64 Basic Authentication 78fa3af tests/tests_app/utilities/test_login.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Merging #19293 (4bff3b2) into master (4996965) will decrease coverage by 29%.
Report is 1 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19293      +/-   ##
==========================================
- Coverage      84%      54%     -29%     
==========================================
  Files         445      440       -5     
  Lines       37295    37215      -80     
==========================================
- Hits        31149    20170   -10979     
- Misses       6146    17045   +10899     

@awaelchli awaelchli added code quality community This PR is from the community labels Jan 16, 2024
@awaelchli awaelchli added this to the 2.2 milestone Jan 16, 2024
@mergify mergify bot added the ready PRs ready to be merged label Jan 16, 2024
@Borda Borda merged commit dbcfcb9 into Lightning-AI:master Jan 16, 2024
@VictorPrins VictorPrins deleted the #18695_fabric/utilities branch January 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants