-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for TQDMProgressBar to retain prior epoch training bars #19578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
Documentation related
pl
Generic label for PyTorch Lightning package
labels
Mar 5, 2024
jojje
force-pushed
the
feat/leave-progressbar
branch
from
March 5, 2024 17:45
0148c20
to
f35de36
Compare
jojje
requested review from
williamFalcon,
awaelchli,
carmocca,
justusschock,
lantiga and
Borda
as code owners
March 5, 2024 19:00
awaelchli
reviewed
Mar 8, 2024
awaelchli
changed the title
Add ability for TQDMProgressBar to retain prior epoch training bars (…
Add ability for TQDMProgressBar to retain prior epoch training bars
Aug 4, 2024
awaelchli
approved these changes
Aug 4, 2024
ammyk9
pushed a commit
to ammyk9/pytorch-lightning
that referenced
this pull request
Aug 6, 2024
…ightning-AI#19578) Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19578 +/- ##
=========================================
- Coverage 89% 81% -8%
=========================================
Files 267 264 -3
Lines 23045 22995 -50
=========================================
- Hits 20547 18588 -1959
- Misses 2498 4407 +1909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
This PR is from the community
docs
Documentation related
pl
Generic label for PyTorch Lightning package
progress bar: tqdm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to retain tqdm progress bars from prior training epochs.
Fixes #19322
Before submitting
A: No, an issue was was opened but there is no PR yet to discuss (catch 22).
A: Yes.
A: No. The goal was to not break any existing behavior so the existing TQDMProgressBar test suite was used to ensure that objective.
A: Partly, I only ran the TQDMProgressBar test suite, since the other's mostly failed on my machine even before the change was made. As such am submitting a draft PR to ensure the entire test suite passes using the project's CI system before it's worth discussing the PR.
A: N/A, No breaking changes intended.
A: Yes
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19578.org.readthedocs.build/en/19578/