Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for TQDMProgressBar to retain prior epoch training bars #19578

Merged
merged 9 commits into from
Aug 4, 2024

Conversation

jojje
Copy link
Contributor

@jojje jojje commented Mar 5, 2024

What does this PR do?

Adds the ability to retain tqdm progress bars from prior training epochs.

Fixes #19322

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs).
    A: No, an issue was was opened but there is no PR yet to discuss (catch 22).
  • [ X ] Did you read the contributor guideline, Pull Request section?
  • [ X ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
    A: Yes.
  • Did you write any new necessary tests? (not for typos and docs)
    A: No. The goal was to not break any existing behavior so the existing TQDMProgressBar test suite was used to ensure that objective.
  • [ X ] Did you verify new and existing tests pass locally with your changes?
    A: Partly, I only ran the TQDMProgressBar test suite, since the other's mostly failed on my machine even before the change was made. As such am submitting a draft PR to ensure the entire test suite passes using the project's CI system before it's worth discussing the PR.
  • Did you list all the breaking changes introduced by this pull request?
    A: N/A, No breaking changes intended.
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors):
    A: Yes

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19578.org.readthedocs.build/en/19578/

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Mar 5, 2024
@jojje jojje force-pushed the feat/leave-progressbar branch from 0148c20 to f35de36 Compare March 5, 2024 17:45
@awaelchli awaelchli added this to the 2.3 milestone Mar 8, 2024
@awaelchli awaelchli added the community This PR is from the community label Mar 8, 2024
@awaelchli awaelchli self-assigned this Mar 8, 2024
@awaelchli awaelchli modified the milestones: 2.3, future Jun 6, 2024
@awaelchli awaelchli requested a review from tchaton as a code owner August 4, 2024 01:06
@mergify mergify bot removed the has conflicts label Aug 4, 2024
@awaelchli awaelchli changed the title Add ability for TQDMProgressBar to retain prior epoch training bars (… Add ability for TQDMProgressBar to retain prior epoch training bars Aug 4, 2024
@awaelchli awaelchli modified the milestones: future, 2.4 Aug 4, 2024
@awaelchli awaelchli merged commit e61eafa into Lightning-AI:master Aug 4, 2024
72 of 73 checks passed
ammyk9 pushed a commit to ammyk9/pytorch-lightning that referenced this pull request Aug 6, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81%. Comparing base (83ba2df) to head (df114b6).
Report is 39 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (83ba2df) and HEAD (df114b6). Click for more details.

HEAD has 90 uploads less than BASE
Flag BASE (83ba2df) HEAD (df114b6)
gpu 4 2
pytest 25 2
lightning_fabric 7 0
cpu 42 21
python3.10 12 6
python3.9 12 6
lightning 32 16
python3.11 12 6
python3.12 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #19578     +/-   ##
=========================================
- Coverage      89%      81%     -8%     
=========================================
  Files         267      264      -3     
  Lines       23045    22995     -50     
=========================================
- Hits        20547    18588   -1959     
- Misses       2498     4407   +1909     

@jojje jojje deleted the feat/leave-progressbar branch November 3, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package progress bar: tqdm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats logging in "on_train_epoch_end" ends up on wrong progress bar
2 participants