-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App] fix HTTPClient retry for flow/work queue #19837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
May 1, 2024
awaelchli
approved these changes
May 1, 2024
lantiga
changed the title
App: fix HTTPClient retry for flow/work queue
[App] fix HTTPClient retry for flow/work queue
May 1, 2024
rusenask
approved these changes
May 1, 2024
awaelchli
added a commit
that referenced
this pull request
May 1, 2024
awaelchli
added a commit
that referenced
this pull request
May 1, 2024
Co-authored-by: Luca Antiga <luca@lightning.ai>
lantiga
added a commit
that referenced
this pull request
May 1, 2024
Co-authored-by: Luca Antiga <luca@lightning.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
bug
Something isn't working
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue with HTTPClient for the queue not retrying correctly in the app framework.
This PR changes the retry policy on the HTTPClient to:
📚 Documentation preview 📚: https://pytorch-lightning--19837.org.readthedocs.build/en/19837/
cc @Borda