Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release 2.2.5 #19893

Merged
merged 5 commits into from
May 22, 2024
Merged

Patch release 2.2.5 #19893

merged 5 commits into from
May 22, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 22, 2024 •
edited by github-actions bot
Loading

Bug fixes cherry-picked since last release.

cc @Borda @carmocca @justusschock @awaelchli

tchaton and others added 4 commits May 22, 2024 13:45
@tchaton @awaelchli
Reduce queue fetching (#19856)
9daf652 
* update

* update
@tchaton @awaelchli
Update Lightning Cloud 0.5.69 (#19857)
04a49cd
@lantiga @awaelchli
[App] Extend retry to 4xx except 400, 401, 403, 404 (#19842)
3c43148 
* Extend retry to 4xx except 400, 401, 403, 404

* Remove unused intersphinx mapping for app

---------

Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
@awaelchli
Fix state dict loading in bitsandbytes plugin when checkpoint is alre…
e1ee230 
…ady quantized (#19886)
@awaelchli awaelchli added bug Something isn't working release labels May 22, 2024
@github-actions github-actions bot added fabric lightning.fabric.Fabric app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file package labels May 22, 2024
@awaelchli awaelchli added this to the 2.2.x milestone May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.2) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success ✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success ✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to docs/source-pytorch/conf.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.11, 2.1) success ✅
fabric-cpu (macOS-11, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success ✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success ✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/precision/bitsandbytes.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success ✅
app-pytest (macOS-11, lightning, 3.8, oldest) success ✅
app-pytest (macOS-11, app, 3.9, latest) success ✅
app-pytest (macOS-12, app, 3.11, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, app, 3.9, latest) success ✅
app-pytest (ubuntu-22.04, app, 3.11, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, oldest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.11, latest) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/network.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/utilities/test_network.py, requirements/app/app.txt.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (macOS-11, lightning, 3.9, oldest) success ✅
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, oldest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/network.py, requirements/app/app.txt.

🟢 lightning_app: Docs
Check ID Status
docs-make (app, doctest) success ✅
docs-make (app, html) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/network.py, docs/source-app/conf.py, requirements/app/app.txt.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/app/app.txt, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/network.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/version.info.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.11) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/network.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/version.info, requirements/app/app.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83%. Comparing base (2a46b0c) to head (59079bd).
Report is 285 commits behind head on release/stable.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release/stable   #19893   +/-   ##
===============================================
- Coverage              83%      83%   -0%     
===============================================
  Files                 425      425           
  Lines               34967    34973    +6     
===============================================
- Hits                29138    29129    -9     
- Misses               5829     5844   +15

@github-actions github-actions bot added the docs Documentation related label May 22, 2024
@mergify mergify bot added the ready PRs ready to be merged label May 22, 2024
@awaelchli awaelchli merged commit ac3f1ee into release/stable May 22, 2024
135 checks passed
@awaelchli awaelchli deleted the draft-2.2.5 branch May 22, 2024 17:19
@awaelchli
Copy link
Contributor Author

I accidentally merged with the squash option, should have been rebase+merge. Apologies, I hope it doesn't impact anybody's life 😬

@Borda
Copy link
Member

Borda commented May 22, 2024 •
edited
Loading

I accidentally merged with the squash option, should have been rebase+merge. Apologies, I hope it doesn't impact anybody's life 😬

Just yours if you will do some more releases and compare the git history with the change log... 🦩
UPDATE: also until it is pushed to pypi, you can always reset the stable branch and create new PR to be merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@lantiga lantiga lantiga approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package bug Something isn't working dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package ready PRs ready to be merged release
Projects
None yet
Milestone
2.2.x
Development

Successfully merging this pull request may close these issues.
5 participants
@awaelchli @Borda @lantiga @carmocca @tchaton