Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing numpy package from src/lightning #19959

Closed
wants to merge 4 commits into from

Conversation

Bhavay-2001
Copy link
Contributor

@Bhavay-2001 Bhavay-2001 commented Jun 7, 2024

What does this PR do?

Fixes #16649

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Tagging @awaelchli for better visibility.

Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19959.org.readthedocs.build/en/19959/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 7, 2024
@Bhavay-2001
Copy link
Contributor Author

Hi @awaelchli,
I am trying to change the numpy package in this piece of code in the src\lightning\fabric\utilities\logger.py

if isinstance(params[k], (np.bool_, np.integer, np.floating)):
    params[k] = params[k].item()
elif type(params[k]) not in [bool, int, float, str, Tensor]:
    params[k] = str(params[k])

I tried to change np.bool_ to torch.bool but it is giving an error saying torch.bool is not a type.
Could you pls suggest what I am doing wrong here?

@lantiga
Copy link
Collaborator

lantiga commented Jul 4, 2024

torch.bool is actually an instance of torch.dtype

>>> type(torch.bool)
<class 'torch.dtype'>

so you need to check if something.dtype == torch.bool

@awaelchli
Copy link
Contributor

Superseded by #20055, which needed a different approach. #16649 is now completed, thanks for the help!

@awaelchli awaelchli closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the numpy requirement
3 participants