Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable import lightning.app if it is installed #20059

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 8, 2024

What does this PR do?

Enables continues using lightning.app if it is installed and test it

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20059.org.readthedocs.build/en/20059/

@github-actions github-actions bot added ci Continuous Integration dependencies Pull requests that update a dependency file labels Jul 8, 2024
@Borda Borda changed the title copy init enable import lightning.app if it is installed Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

🌩️ Required checks status: Pending 🟡

Groups summary

🟡 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric latest) no_status
lightning-fabric (GPUs) (testing Lightning latest) no_status

These checks are required after the changes to examples/fabric/tensor_parallel/train.py.

🟡 mypy
Check ID Status
mypy no_status

These checks are required after the changes to requirements/app/app.txt, src/lightning/app/__init__.py.

🟡 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.8) no_status
install-pkg (ubuntu-22.04, fabric, 3.11) no_status
install-pkg (ubuntu-22.04, pytorch, 3.8) no_status
install-pkg (ubuntu-22.04, pytorch, 3.11) no_status
install-pkg (ubuntu-22.04, lightning, 3.8) no_status
install-pkg (ubuntu-22.04, lightning, 3.11) no_status
install-pkg (ubuntu-22.04, notset, 3.8) no_status
install-pkg (ubuntu-22.04, notset, 3.11) no_status
install-pkg (macOS-12, fabric, 3.8) no_status
install-pkg (macOS-12, fabric, 3.11) no_status
install-pkg (macOS-12, pytorch, 3.8) no_status
install-pkg (macOS-12, pytorch, 3.11) no_status
install-pkg (macOS-12, lightning, 3.8) no_status
install-pkg (macOS-12, lightning, 3.11) no_status
install-pkg (macOS-12, notset, 3.8) no_status
install-pkg (macOS-12, notset, 3.11) no_status
install-pkg (windows-2022, fabric, 3.8) no_status
install-pkg (windows-2022, fabric, 3.11) no_status
install-pkg (windows-2022, pytorch, 3.8) no_status
install-pkg (windows-2022, pytorch, 3.11) no_status
install-pkg (windows-2022, lightning, 3.8) no_status
install-pkg (windows-2022, lightning, 3.11) no_status
install-pkg (windows-2022, notset, 3.8) no_status
install-pkg (windows-2022, notset, 3.11) no_status

These checks are required after the changes to .github/workflows/ci-pkg-install.yml, src/lightning/app/__init__.py, requirements/app/app.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Jul 8, 2024
@Borda Borda mentioned this pull request Jul 8, 2024
@Borda Borda changed the base branch from master to draft-release-2-3-3 July 8, 2024 11:02
@Borda Borda requested a review from williamFalcon as a code owner July 8, 2024 11:02
@mergify mergify bot added the has conflicts label Jul 8, 2024
@Borda Borda merged commit cd2a1f2 into draft-release-2-3-3 Jul 8, 2024
5 of 9 checks passed
@Borda Borda deleted the pkg/app branch July 8, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric has conflicts package pl Generic label for PyTorch Lightning package release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant