Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid printing the seed info message multiple times #20108

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Avoid printing the seed info message multiple times #20108

merged 4 commits into from
Jul 20, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 20, 2024 •
edited
Loading

What does this PR do?

We have a mechanism internally to reset the seed (e.g. in new subprocesses for ddp-spawn or after the sanity validation loop). However, this will repeat the printout of the seeding info multiple times:

[rank: 6] Seed set to 42
[rank: 4] Seed set to 42
[rank: 7] Seed set to 42
[rank: 5] Seed set to 42
[rank: 4] Seed set to 42
Initializing distributed: GLOBAL_RANK: 4, MEMBER: 5/8
[rank: 6] Seed set to 42
[rank: 7] Seed set to 42
[rank: 5] Seed set to 42
Initializing distributed: GLOBAL_RANK: 5, MEMBER: 6/8
Initializing distributed: GLOBAL_RANK: 7, MEMBER: 8/8
Initializing distributed: GLOBAL_RANK: 6, MEMBER: 7/8
Missing logger folder: /teamspace/studios/this_studio/lightning_logs
----------------------------------------------------------------------------------------------------
Distributed backend: NCCL
All distributed processes registered. Starting with 8 processes
----------------------------------------------------------------------------------------------------

...

The intention is to show it only once per rank. This PR adds a verbose flag that we can set to False when calling it internally. At the same time, this also gives the user the possibility to suppress the message if they don't want to see it.

📚 Documentation preview 📚: https://pytorch-lightning--20108.org.readthedocs.build/en/20108/

cc @carmocca @justusschock @awaelchli

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jul 20, 2024
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 20, 2024
@awaelchli awaelchli marked this pull request as ready for review July 20, 2024 14:01
@awaelchli awaelchli added bug Something isn't working fun Staff contributions outside working hours - to differentiate from the "community" label labels Jul 20, 2024
@awaelchli awaelchli modified the milestones: 2.3.x, 2.4 Jul 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 20, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-12, pytorch, 3.10, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.10, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-12, fabric, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py, tests/tests_fabric/utilities/test_seed.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py, tests/tests_fabric/utilities/test_seed.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.9) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.9) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.9) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.9) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.9) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.9) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.9) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.9) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.9) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.9) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.9) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/seed.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Jul 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90%. Comparing base (1cd7741) to head (2ce7b21).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20108   +/-   ##
=======================================
- Coverage      91%      90%   -0%     
=======================================
  Files         266      266           
  Lines       22984    22985    +1     
=======================================
- Hits        20816    20793   -23     
- Misses       2168     2192   +24

@awaelchli awaelchli merged commit d0a6b34 into master Jul 20, 2024
112 of 117 checks passed
@awaelchli awaelchli deleted the feature/reset-seed-info branch July 20, 2024 18:25
ammyk9 pushed a commit to ammyk9/pytorch-lightning that referenced this pull request Aug 6, 2024
@awaelchli @ammyk9
Avoid printing the seed info message multiple times (Lightning-AI#20108)
08fe9ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working fabric lightning.fabric.Fabric fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@awaelchli @Borda