Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type check workflow to PyTorch 2.4 #20155

Merged
merged 7 commits into from
Aug 3, 2024
Merged

Update type check workflow to PyTorch 2.4 #20155

merged 7 commits into from
Aug 3, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 3, 2024 •
edited by github-actions bot
Loading

What does this PR do?

Updates the version of PyTorch in the mypy type check workflow to 2.4 and resolves the type errors/warnings in the latest mypy version.

📚 Documentation preview 📚: https://pytorch-lightning--20155.org.readthedocs.build/en/20155/

cc @Borda @carmocca @justusschock @awaelchli

@awaelchli awaelchli added this to the 2.4 milestone Aug 3, 2024
@github-actions github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Aug 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 3, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, lightning, 3.12, 2.4) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.12, 2.4) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.12, 2.4) success ✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-12, pytorch, 3.10, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.10, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/pruning.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/model_helpers.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/pruning.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/model_helpers.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/pruning.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/model_helpers.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py, docs/source-fabric/conf.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/pruning.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/model_helpers.py, docs/source-pytorch/conf.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.4) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.12, 2.4) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.4) success ✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-12, fabric, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to .github/workflows/code-checks.yml, requirements/typing.txt, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/pruning.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/model_helpers.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.9) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.9) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.9) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.9) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.9) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.9) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.9) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.9) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.9) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.9) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.9) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/plugins/precision/amp.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/fabric/utilities/logger.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/pruning.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/amp.py, src/lightning/pytorch/plugins/precision/precision.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/tuner/lr_finder.py, src/lightning/pytorch/utilities/model_helpers.py, requirements/typing.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Aug 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (b5695c5) to head (fcb0da6).
Report is 42 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #20155    +/-   ##
========================================
+ Coverage      88%      89%    +1%     
========================================
  Files         267      267            
  Lines       23044    23045     +1     
========================================
+ Hits        20250    20547   +297     
+ Misses       2794     2498   -296

@github-actions github-actions bot added the docs Documentation related label Aug 3, 2024
@awaelchli awaelchli merged commit 1bc2aad into master Aug 3, 2024
104 of 106 checks passed
@awaelchli awaelchli deleted the tests/torch-mypy branch August 3, 2024 13:49
@awaelchli awaelchli added the fun Staff contributions outside working hours - to differentiate from the "community" label label Aug 4, 2024
ammyk9 pushed a commit to ammyk9/pytorch-lightning that referenced this pull request Aug 6, 2024
@awaelchli @ammyk9
Update type check workflow to PyTorch 2.4 (Lightning-AI#20155)
f22d0bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration code quality dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@awaelchli @Borda