Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter count in ModelSummary when parameters are DTensors #20163

Merged
merged 8 commits into from
Aug 5, 2024

add comment

d4cdde4
Select commit
Loading
Failed to load commit list.
Merged

Fix parameter count in ModelSummary when parameters are DTensors #20163

add comment
d4cdde4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 5, 2024 in 0s

89% (target 99%)

Details

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (d4de8e2) to head (d4cdde4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20163   +/-   ##
=======================================
- Coverage      89%      89%   -0%     
=======================================
  Files         267      267           
  Lines       23063    23071    +8     
=======================================
+ Hits        20565    20572    +7     
- Misses       2498     2499    +1