Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): update tests after torch 2.4.1 #20302

Merged
merged 6 commits into from
Sep 26, 2024
Merged

fix(tests): update tests after torch 2.4.1 #20302

merged 6 commits into from
Sep 26, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 26, 2024 •
edited by github-actions bot
Loading

What does this PR do?

seems some warnings were updated in the latest 2.4.1 and our tests rely on it

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20302.org.readthedocs.build/en/20302/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file package labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, lightning, 3.12, 2.4) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.12, 2.4) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.12, 2.4) success ✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-12, pytorch, 3.10, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.10, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, pyproject.toml.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, pyproject.toml, src/lightning/fabric/utilities/imports.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, pyproject.toml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.4) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.12, 2.4) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.4) success ✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-12, fabric, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, pyproject.toml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, pyproject.toml.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/typing.txt, src/lightning/fabric/utilities/imports.py, pyproject.toml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.9) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.9) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.9) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.9) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.9) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.9) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.9) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.9) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.9) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.9) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.9) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, requirements/typing.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (e452fe8) to head (8ea7b29).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20302   +/-   ##
=======================================
  Coverage      89%      89%           
=======================================
  Files         267      267           
  Lines       23082    23084    +2     
=======================================
+ Hits        20573    20585   +12     
+ Misses       2509     2499   -10

@Borda Borda changed the title fix(tests): update tests after torch 2.4.1 [wip] fix(tests): update tests after torch 2.4.1 Sep 26, 2024
@lexierule lexierule merged commit d1ca3c6 into master Sep 26, 2024
105 of 106 checks passed
@lexierule lexierule deleted the test/fix-warn branch September 26, 2024 15:52
Borda added a commit that referenced this pull request Sep 26, 2024
@Borda
fix(tests): update tests after torch 2.4.1 (#20302)
143b6d0 
* update

* test_loggers_pickle_all

* more...

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit d1ca3c6)
lexierule pushed a commit that referenced this pull request Sep 27, 2024
@Borda @lexierule
fix(tests): update tests after torch 2.4.1 (#20302)
2d801f2 
* update

* test_loggers_pickle_all

* more...

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit d1ca3c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @ethanwharris @lexierule