Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase acc #2039

Merged
merged 7 commits into from
Jun 3, 2020
Merged

increase acc #2039

merged 7 commits into from
Jun 3, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 1, 2020

What does this PR do?

Fixes #2029. See #2029 (comment)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Jun 1, 2020
@Borda Borda added this to the 0.8.0 milestone Jun 1, 2020
@mergify mergify bot requested a review from a team June 1, 2020 17:14
@Borda Borda requested a review from williamFalcon June 1, 2020 17:14
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #2039 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2039   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files          74      74           
  Lines        4710    4710           
======================================
  Hits         4066    4066           
  Misses        644     644           

@Borda Borda marked this pull request as ready for review June 1, 2020 17:24
@Borda Borda added bug Something isn't working priority: 0 High priority task labels Jun 1, 2020
@mergify mergify bot requested a review from a team June 1, 2020 17:42
@Borda Borda marked this pull request as draft June 1, 2020 17:45
@Borda Borda force-pushed the tests/increase-acc branch from 749e4ce to a9b39ad Compare June 1, 2020 17:47
@Borda Borda marked this pull request as ready for review June 1, 2020 18:40
@Borda
Copy link
Member Author

Borda commented Jun 2, 2020

seems we have a hanging test for macOS and py3.8
https://github.com/PyTorchLightning/pytorch-lightning/pull/2044/checks?check_run_id=728728190
@williamFalcon it is already from master

@Borda
Copy link
Member Author

Borda commented Jun 2, 2020

@SkafteNicki this test is causing problem on macOS and py3.8
tests/loggers/test_all.py::test_logger_reset_correctly[Batch-size-Finder]
it is hanging there infinitely long and then the test is timeouted... any idea why?

@SkafteNicki
Copy link
Member

@Borda not completly sure why it is failing specific on mac. Do you know how much RAM the machines have the test are running on? Since the test currently are evaluated on cpu, it is only when the RAM is filled up we get an OOM error and the search stops. Maybe it would help switching these tests to gpu, since the memory is smaller the test will be faster?

@Borda
Copy link
Member Author

Borda commented Jun 2, 2020

@SkafteNicki it is running on the very same servers, just different images...
also, it is failing on just one particular configuration...

@SkafteNicki
Copy link
Member

@Borda am I reading the checks correct, that it works on mac with python 3.7 but not with python 3.8?

setup.cfg Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 2, 2020 15:43
@Borda
Copy link
Member Author

Borda commented Jun 2, 2020

@Borda am I reading the checks correct, that it works on mac with python 3.7 but not with python 3.8?

exactly... :]

@Borda Borda mentioned this pull request Jun 2, 2020
@Borda Borda reopened this Jun 3, 2020
@Borda
Copy link
Member Author

Borda commented Jun 3, 2020

This solves the issue with invalid accuracy tests...

@williamFalcon williamFalcon merged commit c438d0d into master Jun 3, 2020
@Borda Borda deleted the tests/increase-acc branch June 3, 2020 12:37
justusschock pushed a commit that referenced this pull request Jun 29, 2020
* increase acc

* try 0.45

* @pytest

* @pytest

* try .50

* duration

* pytest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants