bump python 3.9+ #20413
bump python 3.9+ #20413
Conversation
github-actions
bot
added
docs
for more information, see https://pre-commit.ci
Borda
requested review from
justusschock,
williamFalcon,
lantiga,
tchaton and
ethanwharris
as code owners
⛈️ Required checks status: Has failure 🔴
Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🔴 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🔴 lightning_fabric: CPU workflowThese checks are required after the changes to 🔴 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20413 +/- ##
=========================================
+ Coverage 75% 87% +12%
=========================================
Files 267 267
Lines 23203 23266 +63
=========================================
+ Hits 17375 20252 +2877
+ Misses 5828 3014 -2814 |
Borda
force-pushed
the
bump/python_3.9+
branch
from
8b8bb2e
to
7858262
Compare
crashing on MacOS for PT 2.1 |
should be mostly flaky, but I wonder if we should bump all pt 2.1 to 2.1.2, too. |
right, but the failing was quite consistent and happened quite often so we may consider doing a rerun...
do you mean but package dependency or just for testing/CI |
| from itertools import chain | ||
| from os.path import dirname, isfile | ||
| from pathlib import Path | ||
| from typing import Any, Dict, Iterable, Iterator, List, Optional, Sequence, Tuple | ||
| from typing import Any, Optional |
There was a problem hiding this comment.
Given the amount of changes and expecting a fair number of merge conflicts, I'd recommend merging all other patches immediately ready first and then push this.
good call, let's hold it as the last one 🦩 |
mergify
bot
added
ready
mergify
bot
added
ready
What does this PR do?
Python 3.8 is not live, let's bump...
endoflife.date/python
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20413.org.readthedocs.build/en/20413/
cc @Borda @justusschock @awaelchli