-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start accumulate gradients schedule at epoch 0 (continued) #2513
Merged
williamFalcon
merged 7 commits into
Lightning-AI:master
from
HHousen:bugfix/2480_grad-accumulate-0-epoch
Jul 9, 2020
Merged
Start accumulate gradients schedule at epoch 0 (continued) #2513
williamFalcon
merged 7 commits into
Lightning-AI:master
from
HHousen:bugfix/2480_grad-accumulate-0-epoch
Jul 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #2513 +/- ##
======================================
- Coverage 88% 87% -1%
======================================
Files 69 69
Lines 5540 5628 +88
======================================
- Hits 4900 4899 -1
- Misses 640 729 +89 |
awaelchli
approved these changes
Jul 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this looks good!
Hello @HHousen! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-06 00:24:32 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continuation of #2490.
Fixes #2480. If the
pl.Trainer
optionaccumulate_grad_batches
was an integer then the first epoch (epoch 0) would useaccumulate_grad_batches=1
while the remaining epochs would useaccumulate_grad_batches=<user_value>
. This was caused by #2289.Before:
After:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃