Add filename parameter to ModelCheckpoint #2584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Jul 11, 2020
Borda
requested changes
Jul 15, 2020
Collaborator
Borda
left a comment
Borda
left a comment
There was a problem hiding this comment.
@PyTorchLightning/core-contributors mind check this API update?
| def __init__(self, filepath: Optional[str] = None, monitor: str = 'val_loss', verbose: bool = False, | ||
| save_last: bool = False, save_top_k: int = 1, save_weights_only: bool = False, | ||
| mode: str = 'auto', period: int = 1, prefix: str = ''): | ||
| mode: str = 'auto', period: int = 1, prefix: str = '', filename: Optional[str] = None): |
Collaborator
There was a problem hiding this comment.
missing docs for the new parameter
Borda
requested review from
SkafteNicki,
awaelchli,
jeremyjordan and
williamFalcon
Contributor
|
This pull request is now in conflict... :( |
Contributor
|
This pull request is now in conflict... :( |
7 tasks
Contributor
|
I think this is a good feature, having separate dirpath and filename solves a lot of issues. I prefer it should be |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds filename parameter to ModelCheckpoint. See issue #2583.