Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify tests & cleaning #2588

Merged
merged 9 commits into from
Aug 7, 2020
Merged

simplify tests & cleaning #2588

merged 9 commits into from
Aug 7, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 11, 2020

What does this PR do?

cleaning after #2587
lover test accuracy fro ddp test and increase nb epochs
rename accelerator_backends to accelerators

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Jul 11, 2020
@mergify mergify bot requested a review from a team July 11, 2020 22:26
@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #2588 into master will decrease coverage by 7%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2588    +/-   ##
=======================================
- Coverage      90%     84%    -7%     
=======================================
  Files          79      79            
  Lines        7192    7995   +803     
=======================================
+ Hits         6496    6690   +194     
- Misses        696    1305   +609     

@Borda Borda marked this pull request as draft July 13, 2020 14:44
@Borda Borda added the won't fix This will not be worked on label Jul 29, 2020
@Borda Borda marked this pull request as ready for review August 2, 2020 22:44
@stale stale bot removed the won't fix This will not be worked on label Aug 2, 2020
@Borda Borda force-pushed the tests/func-assert branch from e95d135 to ec398fb Compare August 2, 2020 22:47
@Borda Borda added this to the 0.9.0 milestone Aug 6, 2020
@Borda Borda added the ready PRs ready to be merged label Aug 6, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2020

This pull request is now in conflict... :(

@Borda Borda force-pushed the tests/func-assert branch from fd13796 to 8acbfac Compare August 6, 2020 21:30
@mergify mergify bot requested a review from a team August 7, 2020 06:25
@Borda Borda changed the title simplify tests simplify tests & cleaning Aug 7, 2020
@mergify mergify bot requested a review from a team August 7, 2020 09:20
@mergify mergify bot requested a review from a team August 7, 2020 20:37
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
tests/core/test_datamodules.py Outdated Show resolved Hide resolved
@Borda Borda merged commit f8c0582 into master Aug 7, 2020
@Borda Borda deleted the tests/func-assert branch August 7, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants