-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify tests & cleaning #2588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2588 +/- ##
=======================================
- Coverage 90% 84% -7%
=======================================
Files 79 79
Lines 7192 7995 +803
=======================================
+ Hits 6496 6690 +194
- Misses 696 1305 +609 |
Borda
force-pushed
the
tests/func-assert
branch
from
August 2, 2020 22:47
e95d135
to
ec398fb
Compare
Borda
requested review from
awaelchli,
ethanwharris,
justusschock,
rohitgr7 and
yukw777
August 6, 2020 20:48
This pull request is now in conflict... :( |
Borda
force-pushed
the
tests/func-assert
branch
from
August 6, 2020 21:30
fd13796
to
8acbfac
Compare
justusschock
approved these changes
Aug 7, 2020
SkafteNicki
approved these changes
Aug 7, 2020
awaelchli
reviewed
Aug 7, 2020
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Borda
commented
Aug 7, 2020
awaelchli
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cleaning after #2587
lover test accuracy fro ddp test and increase nb epochs
rename accelerator_backends to accelerators
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃