Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: run_pretrain_routine -> setup_training #3294

Merged
merged 2 commits into from
Aug 31, 2020
Merged

ref: run_pretrain_routine -> setup_training #3294

merged 2 commits into from
Aug 31, 2020

Conversation

williamFalcon
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 31, 2020 21:51
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #3294 into master will increase coverage by 3%.
The diff coverage is 46%.

@@           Coverage Diff           @@
##           master   #3294    +/-   ##
=======================================
+ Coverage      86%     89%    +3%     
=======================================
  Files          88      88            
  Lines        8119    8328   +209     
=======================================
+ Hits         6955    7394   +439     
+ Misses       1164     934   -230     

@williamFalcon williamFalcon merged commit bcd13f7 into master Aug 31, 2020
@Borda Borda added the refactor label Sep 1, 2020
@Borda Borda added this to the 0.9.x milestone Sep 1, 2020
@Borda Borda deleted the reff4 branch September 1, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants