Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch jit ignore decorator to Lightning properties #3295

Closed
wants to merge 1 commit into from
Closed

Add torch jit ignore decorator to Lightning properties #3295

wants to merge 1 commit into from

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Aug 31, 2020

What does this PR do?

This PyTorch PR adds support to TorchScript for module properties, and as a result, these module properties in Lightning will no longer compile because they use unsupported features in their properties (that are now being compiled)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • [] Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

[PR](pytorch/pytorch#42390) adds support to Torchscript for module properties, and as a result, these module properties in Lghtning will no longer compile because they use unsupported features in their properties (that are now being compiled)
@mergify mergify bot requested a review from a team August 31, 2020 23:05
@mergify mergify bot requested a review from a team September 1, 2020 06:46
@Borda Borda added the bug Something isn't working label Sep 1, 2020
@Borda Borda added this to the 0.9.x milestone Sep 1, 2020
@Borda
Copy link
Member

Borda commented Sep 1, 2020

@ananthsub seems all tests are failing, mind have a look?
E RuntimeError: Argument to @torch.jit.ignore must be a bool or a function but got <property object at 0x7f7506a384a8>

@thomasjo
Copy link

thomasjo commented Sep 1, 2020

@Borda The upstream PR hasn't been merged yet. This PR cannot be merged before the upstream PR is merged and available in a stable PyTorch release (possibly 1.7).

@Borda
Copy link
Member

Borda commented Sep 1, 2020

@Borda The upstream PR hasn't been merged yet. This PR cannot be merged before the upstream PR is merged and available in a stable PyTorch release (possibly 1.7).

well, even 1.7 is out we need to maintain compatibility for pt<1.7 so we cannot merge it until this change is compatible also with older PT versions...

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to maintain compatibility with all supported PT versions, and this is valid only for the upcoming PT 1.7

@mergify mergify bot requested a review from a team September 1, 2020 09:47
@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2020

This pull request is now in conflict... :(

@ydcjeff ydcjeff mentioned this pull request Sep 24, 2020
7 tasks
@ananthsub
Copy link
Contributor Author

this was handled by #3541

@ananthsub ananthsub closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants