Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Renaming of precision recall metric #3308

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #3057
Make naming more consistent between the functional and class based backend and is also consistent with sklearn naming.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team September 1, 2020 17:53
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #3308 into master will increase coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3308    +/-   ##
=======================================
+ Coverage      86%     90%    +5%     
=======================================
  Files          88      88            
  Lines        8132    8132            
=======================================
+ Hits         6962    7337   +375     
+ Misses       1170     795   -375     

@williamFalcon williamFalcon merged commit b66ce88 into Lightning-AI:master Sep 1, 2020
@SkafteNicki SkafteNicki deleted the metrics/precision_recall_curve_naming branch October 8, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename class metrics PrecisionRecall to PrecisionRecallCurve and update examples
2 participants