Ref: Pull duplicate data interface definition up into DataHooks class #3344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2707
The PyTorch Lightning codebase must maintain a high quality. Code duplication is a source of bugs, hard to maintain and challenges the sanity of all developers involved.
By pulling the data related hooks up into a common super class / interface, we can maintain the documentation and specification in one place while implementing specific behaviour in subclasses. For example, the datamodule defines the dataloader methods as abstract, while the LightningModule does not. We can override the methods in the DataModule base class and decorate them as abstract, while still inheriting the docstring from the super class.
Before submitting