Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: inner train loop (intermediate step) 10/n #3369

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Conversation

williamFalcon
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

Hello @williamFalcon! Thanks for opening this PR.

Line 817:21: E731 do not assign a lambda expression, use a def

Do see the Hitchhiker's guide to code style

@mergify mergify bot requested a review from a team September 6, 2020 12:22
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #3369 into master will increase coverage by 4%.
The diff coverage is 79%.

@@           Coverage Diff           @@
##           master   #3369    +/-   ##
=======================================
+ Coverage      86%     90%    +4%     
=======================================
  Files          93      93            
  Lines        8244    8321    +77     
=======================================
+ Hits         7056    7456   +400     
+ Misses       1188     865   -323     

@williamFalcon williamFalcon merged commit 8542146 into master Sep 6, 2020
@Borda Borda deleted the refa9 branch September 7, 2020 08:18
@Borda Borda added this to the 0.9.x milestone Sep 9, 2020
@Borda Borda added the refactor label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants