Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove inner train loop 1/n #3397

Merged
merged 2 commits into from
Sep 8, 2020
Merged

ref: remove inner train loop 1/n #3397

merged 2 commits into from
Sep 8, 2020

Conversation

williamFalcon
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Sep 8, 2020

Hello @williamFalcon! Thanks for updating this PR.

Line 492:21: E731 do not assign a lambda expression, use a def

Comment last updated at 2020-09-08 13:40:54 UTC

@mergify mergify bot requested a review from a team September 8, 2020 13:39
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #3397 into master will increase coverage by 5%.
The diff coverage is 96%.

@@           Coverage Diff           @@
##           master   #3397    +/-   ##
=======================================
+ Coverage      85%     90%    +5%     
=======================================
  Files          97      96     -1     
  Lines        8203    8147    -56     
=======================================
+ Hits         7013    7346   +333     
+ Misses       1190     801   -389     

@williamFalcon williamFalcon merged commit ff5f099 into master Sep 8, 2020
@Borda Borda deleted the refa27 branch September 9, 2020 11:04
@Borda Borda added this to the 0.9.x milestone Sep 9, 2020
@Borda Borda added the refactor label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants