Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning docker image based on base-cuda #3637

Merged
merged 5 commits into from
Sep 24, 2020
Merged

Lightning docker image based on base-cuda #3637

merged 5 commits into from
Sep 24, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Sep 24, 2020

What does this PR do?

Fixes #3074 (review)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

cc: @Borda

@mergify mergify bot requested a review from a team September 24, 2020 05:05
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #3637 into master will increase coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3637    +/-   ##
=======================================
+ Coverage      86%     91%    +5%     
=======================================
  Files         110     110            
  Lines        8058    8058            
=======================================
+ Hits         6914    7314   +400     
+ Misses       1144     744   -400     

@Borda Borda added the feature Is an improvement or enhancement label Sep 24, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this chaining :]

.github/workflows/ci_dockers.yml Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team September 24, 2020 08:37
@mergify mergify bot requested a review from a team September 24, 2020 08:38
@Borda Borda added the ready PRs ready to be merged label Sep 24, 2020
@Borda Borda requested review from williamFalcon, yukw777, a team and nateraw September 24, 2020 17:25
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda merged commit a212013 into Lightning-AI:master Sep 24, 2020
@ydcjeff ydcjeff deleted the docker/lightning branch September 25, 2020 02:53
@ydcjeff ydcjeff mentioned this pull request Sep 25, 2020
7 tasks
@Borda Borda added this to the 0.9.x milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants