change default save_top_k, save_last to None #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @awaelchli! Thanks for updating this PR.
Comment last updated at 2020-09-27 23:11:12 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3680 +/- ##
======================================
- Coverage 86% 86% -0%
======================================
Files 110 110
Lines 8112 8059 -53
======================================
- Hits 6957 6898 -59
- Misses 1155 1161 +6 |
awaelchli
changed the title
carmocca
reviewed
Sep 27, 2020
| assert checkpoint_callback.best_k_models == {} | ||
| assert checkpoint_callback.kth_best_model_path == '' | ||
| # check that no ckpts were created | ||
| assert len(set(os.listdir(tmpdir))) == 0 |
There was a problem hiding this comment.
we don't need the set here, extra from the copy/paste
|
LGTM |
|
nice job @awaelchli ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We broke save_top_k when monitor default was switched to None.
save_top_k only makes sense when we have a metric to monitor.
The only exception is when save_top_k=-1, we want to save all checkpoints of all epochs. This PR re-enables it!
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃