[WIP] ref: part 6 of #3733 #3783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
reviewed
Oct 2, 2020
| if is_master: | ||
| available_gpus = os.environ['CUDA_VISIBLE_DEVICES'].split(',') | ||
| gpu_idx = int(available_gpus[self.trainer.local_rank]) | ||
| gpu_idx = int(os.environ.get('PL_DDP_PID', process_idx)) |
There was a problem hiding this comment.
is_master is never used here. it seems like ddp_train doesn't need the self.mode == 'ddp' check anymore
There was a problem hiding this comment.
Good catch!
might be a weird merge artifact... let me check.
ananthsub
reviewed
Oct 2, 2020
Comment on lines
+147
to
+148
| if 'WORLD_SIZE' in os.environ: | ||
| del os.environ['WORLD_SIZE'] |
There was a problem hiding this comment.
n00b question: should this happen in a teardown step?
There was a problem hiding this comment.
probably haha.
i'm not sure what will happen if we move it though. I want to lock down the tests then we can see where it goes
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-02 11:15:22 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3783 +/- ##
========================================
- Coverage 85% 43% -42%
========================================
Files 110 110
Lines 8537 8582 +45
========================================
- Hits 7293 3708 -3585
- Misses 1244 4874 +3630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: part 6 of #3733