Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: part 7 of #3733 #3802

Merged
merged 2 commits into from
Oct 2, 2020
Merged

ref: part 7 of #3733 #3802

merged 2 commits into from
Oct 2, 2020

Conversation

williamFalcon
Copy link
Contributor

ref: part 7 of #3733

@pep8speaks
Copy link

pep8speaks commented Oct 2, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-02 17:31:42 UTC

@Borda Borda added the refactor label Oct 2, 2020
@mergify mergify bot requested a review from a team October 2, 2020 17:31
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #3802 into master will increase coverage by 4%.
The diff coverage is 37%.

@@           Coverage Diff           @@
##           master   #3802    +/-   ##
=======================================
+ Coverage      85%     90%    +4%     
=======================================
  Files         110     110            
  Lines        8536    8616    +80     
=======================================
+ Hits         7293    7729   +436     
+ Misses       1243     887   -356     

@williamFalcon williamFalcon merged commit 7c6ed1f into master Oct 2, 2020
@williamFalcon williamFalcon deleted the fw2_7 branch October 4, 2020 17:37
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants