Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added broadcast option to tpu #3814

Merged
merged 9 commits into from
Oct 4, 2020

Conversation

lezwon
Copy link
Contributor

@lezwon lezwon commented Oct 3, 2020

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team October 3, 2020 10:46
@lezwon lezwon marked this pull request as draft October 3, 2020 10:48
@pep8speaks
Copy link

pep8speaks commented Oct 3, 2020

Hello @lezwon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-04 00:09:35 UTC

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #3814 into master will increase coverage by 2%.
The diff coverage is 27%.

@@           Coverage Diff           @@
##           master   #3814    +/-   ##
=======================================
+ Coverage      83%     86%    +2%     
=======================================
  Files         112     112            
  Lines        8848    9186   +338     
=======================================
+ Hits         7384    7863   +479     
+ Misses       1464    1323   -141     

result = backend.broadcast(obj)
assert result == ("ver_0.5", "logger_name", 0)

xmp.spawn(test_broadcast, nprocs=8, start_method='fork')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this test!
great job!

@lezwon lezwon marked this pull request as ready for review October 4, 2020 05:36
@mergify mergify bot requested a review from a team October 4, 2020 06:29
@williamFalcon williamFalcon merged commit 4da240e into Lightning-AI:master Oct 4, 2020
@Borda Borda added refactor accelerator: tpu Tensor Processing Unit labels Oct 4, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants