Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early stopping deprecation warning for v0.10.0 #3844

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 4, 2020

Now:

trainer = Trainer(early_stop_callback=True)

From v1.0, it will be removed. Instead, configure it like so:

trainer = Trainer(callbacks=[EarlyStopping(monitor=...)])

In follow up PR, will update tests with this change

@awaelchli awaelchli added design Includes a design discussion v1.0 allowed labels Oct 4, 2020
@awaelchli awaelchli added this to the 1.0 milestone Oct 4, 2020
@mergify mergify bot requested a review from a team October 4, 2020 16:50
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #3844 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3844    +/-   ##
=======================================
- Coverage      83%     82%    -1%     
=======================================
  Files         112     116     +4     
  Lines        8848    9823   +975     
=======================================
+ Hits         7384    8058   +674     
- Misses       1464    1765   +301     

@williamFalcon williamFalcon merged commit 1906867 into master Oct 4, 2020
@awaelchli awaelchli deleted the feature/deprecate-earlystop branch October 4, 2020 17:19
@Borda Borda modified the milestones: 1.0, 0.10.0 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants