Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test selecting the correct backend. temp backends while slurm and TE are decoupled #3848

Merged
merged 2 commits into from
Oct 4, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Oct 4, 2020

Tests to make sure the correct backends are chosen.

The slurm and TE backends are duplicates, but intermediate until they are factored out of the backends.
Ultimate goal is for backends to be independent from slurm and TE

@pep8speaks
Copy link

pep8speaks commented Oct 4, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-04 19:27:03 UTC

@mergify mergify bot requested a review from a team October 4, 2020 19:24
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #3848 into master will increase coverage by 4%.
The diff coverage is 44%.

@@           Coverage Diff           @@
##           master   #3848    +/-   ##
=======================================
+ Coverage      83%     87%    +4%     
=======================================
  Files         115     117     +2     
  Lines        8924    9107   +183     
=======================================
+ Hits         7425    7966   +541     
+ Misses       1499    1141   -358     

@williamFalcon williamFalcon merged commit 70e7923 into master Oct 4, 2020
@Borda Borda deleted the ddp5 branch October 5, 2020 06:12
@Borda Borda added the docs Documentation related label Oct 5, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants