Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes metrics pickle issue #3921

Merged
merged 1 commit into from
Oct 7, 2020
Merged

fixes metrics pickle issue #3921

merged 1 commit into from
Oct 7, 2020

Conversation

ananyahjha93
Copy link
Contributor

Ensures metrics work with pickle.

Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
@mergify mergify bot requested a review from a team October 6, 2020 23:32
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :]

@Borda Borda added bug Something isn't working Metrics labels Oct 6, 2020
@mergify mergify bot requested a review from a team October 6, 2020 23:35
@edenlightning edenlightning added this to the 0.10.0 milestone Oct 6, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #3921 into master will increase coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3921    +/-   ##
=======================================
+ Coverage      82%     86%    +5%     
=======================================
  Files         113     113            
  Lines        8479    8525    +46     
=======================================
+ Hits         6929    7360   +431     
+ Misses       1550    1165   -385     

@williamFalcon williamFalcon merged commit 4cd14c4 into master Oct 7, 2020
@Borda Borda deleted the metrics/pickle branch October 7, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants