-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional metric docs [skip ci] #3946
Conversation
Hello @justusschock! Thanks for opening this PR.
Do see the Hitchhiker's guide to code style |
7ce182d
to
2c06981
Compare
2c06981
to
ebd88a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, Thanks Justus :)
need to merge the latest #3949 to pass the tests |
a11c3a4
to
5f425e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #3946 +/- ##
=======================================
- Coverage 88% 87% -1%
=======================================
Files 109 109
Lines 7827 7764 -63
=======================================
- Hits 6888 6758 -130
- Misses 939 1006 +67 |
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃