Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional metric docs [skip ci] #3946

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Add functional metric docs [skip ci] #3946

merged 3 commits into from
Oct 7, 2020

Conversation

justusschock
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

Hello @justusschock! Thanks for opening this PR.

Line 27:49: E203 whitespace before ':'

Do see the Hitchhiker's guide to code style

@mergify mergify bot requested a review from a team October 7, 2020 17:02
@Borda Borda force-pushed the func_metric_docs branch from 7ce182d to 2c06981 Compare October 7, 2020 17:07
@Borda Borda changed the title Add functional metric docs Add functional metric docs [skip ci] Oct 7, 2020
@Borda Borda added the docs Documentation related label Oct 7, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Copy link
Contributor

@teddykoker teddykoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, Thanks Justus :)

@Borda
Copy link
Member

Borda commented Oct 7, 2020

need to merge the latest #3949 to pass the tests

@Borda Borda requested a review from williamFalcon October 7, 2020 18:19
@Borda Borda force-pushed the func_metric_docs branch from a11c3a4 to 5f425e6 Compare October 7, 2020 18:31
@mergify mergify bot requested a review from a team October 7, 2020 18:36
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #3946 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3946    +/-   ##
=======================================
- Coverage      88%     87%    -1%     
=======================================
  Files         109     109            
  Lines        7827    7764    -63     
=======================================
- Hits         6888    6758   -130     
- Misses        939    1006    +67     

@Borda Borda merged commit bd5621d into master Oct 7, 2020
@Borda Borda deleted the func_metric_docs branch October 7, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants