Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Refactor logging 3/3 [v1] #4552

Merged
merged 27 commits into from
Nov 11, 2020
Merged

[FEAT] Refactor logging 3/3 [v1] #4552

merged 27 commits into from
Nov 11, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 6, 2020 •
edited
Loading

What does this PR do?

Fixes #3813

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 6, 2020 •
edited
Loading

Codecov Report

Merging #4552 (8592000) into master (514cb22) will decrease coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff           @@
##           master   #4552   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         116     116           
  Lines        8907    8873   -34     
======================================
- Hits         8291    8254   -37     
- Misses        616     619    +3

@tchaton tchaton self-assigned this Nov 6, 2020
@tchaton tchaton added priority: 1 Medium priority task feature Is an improvement or enhancement bug Something isn't working labels Nov 6, 2020
@tchaton tchaton added this to the 1.1 milestone Nov 6, 2020
@tchaton tchaton added the logger Related to the Loggers label Nov 6, 2020
@tchaton tchaton changed the title [WIP] Refactor logging 3/n [v1] [FEAT] Refactor logging 3/n [v1] Nov 6, 2020
@tchaton tchaton marked this pull request as ready for review November 6, 2020 16:54
teddykoker
teddykoker approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@teddykoker teddykoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question regarding deepcopy, otherwise looks good to me!

pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py Show resolved Hide resolved
@tchaton tchaton added the ready PRs ready to be merged label Nov 6, 2020
@Borda Borda changed the title [FEAT] Refactor logging 3/n [v1] [FEAT] Refactor logging 3/3 [v1] Nov 6, 2020
Borda
Borda reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fist quick pass, need to study the flow in more detail...

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py Show resolved Hide resolved
pytorch_lightning/trainer/evaluation_loop.py Show resolved Hide resolved
tests/trainer/logging_tests/test_eval_loop_logging_1_0.py Outdated Show resolved Hide resolved
tests/trainer/logging_tests/test_eval_loop_logging_1_0.py Outdated Show resolved Hide resolved
tests/trainer/logging_tests/test_eval_loop_logging_1_0.py Show resolved Hide resolved
SeanNaren
SeanNaren reviewed Nov 7, 2020
View reviewed changes
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits and discussion points but again, neat :)

pytorch_lightning/trainer/evaluation_loop.py Show resolved Hide resolved
pytorch_lightning/trainer/evaluation_loop.py Show resolved Hide resolved
pytorch_lightning/trainer/evaluation_loop.py Show resolved Hide resolved
SeanNaren
SeanNaren approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @tchaton! As discussed offline let's add a followup PRs with some docstrings :)

@SeanNaren SeanNaren mentioned this pull request Nov 9, 2020
Closed
@tchaton tchaton merged commit 3d202f9 into master Nov 11, 2020
@tchaton tchaton deleted the feat/logging_val_1 branch November 11, 2020 17:05
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
@tchaton @Borda
@SeanNaren @rohitgr7
[FEAT] Refactor logging 3/3 [v1] (#4552)
eeefeee 
* wip

* wip check how many tests break

* wip

* resolve some bugs

* resolve more bugs

* resolve 2 bugs

* resolve

* temp fix

* update

* remove useless code

* remove result

* try to resolve bug

* update changelog

* formatting

* remove pl

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@justusschock justusschock justusschock approved these changes

@teddykoker teddykoker teddykoker approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@awaelchli awaelchli Awaiting requested review from awaelchli

@nateraw nateraw Awaiting requested review from nateraw

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working feature Is an improvement or enhancement logger Related to the Loggers priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1
Development

Successfully merging this pull request may close these issues.

Calling module.log(...) within a callback fails
5 participants
@tchaton @Borda @SeanNaren @teddykoker @justusschock