Makes automatic optimization a model attribute #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
requested review from
ananyahjha93,
awaelchli,
Borda,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
|
Hello @justusschock! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-14 04:04:19 UTC |
…pytorch-lightning into automatic_optimization
Codecov Report
@@ Coverage Diff @@
## master #4602 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 8914 8921 +7
======================================
+ Hits 8280 8287 +7
Misses 634 634 |
tchaton
approved these changes
Nov 10, 2020
SeanNaren
approved these changes
Nov 10, 2020
|
@justusschock able to fix the failing codefactor test? |
ydcjeff
approved these changes
Nov 10, 2020
ananthsub
reviewed
Nov 10, 2020
ananthsub
reviewed
Nov 10, 2020
rohitgr7
approved these changes
Nov 10, 2020
s-rog
approved these changes
Nov 11, 2020
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
rohitgr7
added a commit
that referenced
this pull request
Nov 21, 2020
* Makes automatic optimization a model attribute * Update trainer.py * remove setting property in model * Update pytorch_lightning/core/lightning.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Update pytorch_lightning/trainer/trainer.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Update trainer.py Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
|
@justusschock what do you think about a corresponding setter decorator to easily change this on the module? #5169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes automatic optimisation a model property and deprecates the trainer flag. Fixes #4317
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @ananthsub