Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #4880

Merged
merged 13 commits into from
Nov 27, 2020
Merged

Logging #4880

merged 13 commits into from
Nov 27, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 27, 2020

What does this PR do?

This PR restricts self.log usage only into training_step, validation_step, test_step functions + all epoch_end ones.

This PR improves SimpleProfiler as result of the investigation.

Screenshot 2020-11-27 at 18 49 35

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Nov 27, 2020

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-27 19:35:06 UTC

@tchaton tchaton changed the title better simple profiler Optimize logging Nov 27, 2020
@tchaton tchaton self-assigned this Nov 27, 2020
@tchaton tchaton added logger Related to the Loggers design Includes a design discussion labels Nov 27, 2020
@tchaton tchaton added this to the 1.1 milestone Nov 27, 2020
@tchaton tchaton marked this pull request as ready for review November 27, 2020 18:42
@pytest.mark.parametrize('cls_model,max_diff', [
(ParityModuleRNN, 0.05),
(ParityModuleMNIST, 0.99)
(ParityModuleMNIST, 0.22)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW :]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, I increased num_workers to 1 !

@tchaton tchaton changed the title Optimize logging Logging Nov 27, 2020
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #4880 (c6502ad) into master (042152c) will decrease coverage by 0%.
The diff coverage is 71%.

@@          Coverage Diff           @@
##           master   #4880   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         118     118           
  Lines        8992    9029   +37     
======================================
+ Hits         8371    8384   +13     
- Misses        621     645   +24     

@williamFalcon williamFalcon merged commit f677efe into master Nov 27, 2020
@tchaton tchaton deleted the better_simple_profiler branch November 27, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion logger Related to the Loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants