Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate video in docs #4952

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix duplicate video in docs #4952

merged 1 commit into from
Dec 2, 2020

Conversation

edenlightning
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7
Copy link
Contributor

rohitgr7 commented Dec 2, 2020

Hi @edenlightning I actually removed it here: #4629 and made some changes to the docs as required by the PR.

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #4952 (f0cd727) into master (eeae426) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4952   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         124     124           
  Lines        9186    9186           
======================================
  Hits         8487    8487           
  Misses        699     699           

@Borda Borda added ready PRs ready to be merged docs Documentation related labels Dec 2, 2020
@Borda Borda added this to the 1.1 milestone Dec 2, 2020
@Borda Borda merged commit 486006e into master Dec 2, 2020
@Borda Borda deleted the edenlightning-patch-2 branch December 2, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants