Added changeable extension variable for model checkpoints #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhenriklambrechts
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
|
Hello @janhenriklambrechts! Thanks for updating this PR.
Comment last updated at 2020-12-06 12:39:27 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4977 +/- ##
======================================
Coverage 93% 93%
======================================
Files 129 129
Lines 9371 9372 +1
======================================
+ Hits 8688 8689 +1
Misses 683 683 |
|
@janhenriklambrechts can you add a test for this? |
|
@rohitgr7 sure, Ill write a test |
Borda
reviewed
Dec 4, 2020
| @@ -140,6 +140,7 @@ class ModelCheckpoint(Callback): | |||
|
|
|||
| CHECKPOINT_JOIN_CHAR = "-" | |||
| CHECKPOINT_NAME_LAST = "last" | |||
| FILE_EXTENSION = "ckpt" | |||
There was a problem hiding this comment.
Suggested change
| FILE_EXTENSION = "ckpt" | |
| FILE_EXTENSION = ".ckpt" |
lets keep the . as os.path.extsplit(...) holds it too
rohitgr7
previously approved these changes
Dec 5, 2020
awaelchli
approved these changes
Dec 5, 2020
…nstead of epoch for integration test
rohitgr7
approved these changes
Dec 6, 2020
awaelchli
approved these changes
Dec 6, 2020
Borda
pushed a commit
that referenced
this pull request
Dec 6, 2020
* Added changeable extension variable for model checkpoints * Removed whitespace * Removed the last bit of whitespace * Wrote tests for FILE_EXTENSION * Fixed formatting issues * More formatting issues * Simplify test by just using defaults * Formatting to PEP8 * Added dummy class that inherits ModelCheckpoint; run only one batch instead of epoch for integration test * Fixed too much whitespace formatting * some changes Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a variable
FILE_EXTENSIONtoModelCheckpointthat allows the user to change the file extension of their model checkpoints as per #4963Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃