Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Group defaults to WORLD if None #5125

Merged
merged 9 commits into from
Dec 23, 2020
Merged

[bugfix] Group defaults to WORLD if None #5125

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97c8a4b
[bugfix] Group defaults to WORLD if None
Dec 14, 2020
7d86954
Merge branch 'master' into bugfix/5122_default_process_group
Borda Dec 14, 2020
c5f8424
fix no_grad
rohitgr7 Dec 14, 2020
5fc3e88
Update pytorch_lightning/utilities/distributed.py
rohitgr7 Dec 14, 2020
e44070b
Update pytorch_lightning/utilities/distributed.py
rohitgr7 Dec 14, 2020
0813e93
Merge branch 'master' into bugfix/5122_default_process_group
rohitgr7 Dec 16, 2020
cb292c9
Merge branch 'master' into bugfix/5122_default_process_group
Borda Dec 16, 2020
a433756
Merge branch 'master' into bugfix/5122_default_process_group
SeanNaren Dec 17, 2020
9b85cf3
Merge branch 'master' into bugfix/5122_default_process_group
Borda Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pytorch_lightning/utilities/distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ def all_gather_ddp_if_available(
Return:
A tensor of shape (world_size, batch, ...)
"""
group = group if group is not None else torch.distributed.group.WORLD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved inside the if statement as torch.distributed.group.WORLD is not defined on windows?

if torch.distributed.is_available() and torch.distributed.is_initialized():
if sync_grads:
return AllGatherGrad.apply(tensor, group)
Expand Down