Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pl optimizer temporarily to fix AMP issues #5163

Merged
merged 7 commits into from
Dec 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/trainer/trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def __init__(
distributed_backend: Optional[str] = None,
automatic_optimization: Optional[bool] = None,
move_metrics_to_cpu: bool = False,
enable_pl_optimizer: bool = True,
enable_pl_optimizer: bool = False,
):
r"""
Customize every aspect of training via flags
Expand Down
2 changes: 2 additions & 0 deletions tests/callbacks/test_callbacks.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ def test_trainer_callback_system(torch_save):
limit_train_batches=3,
limit_test_batches=2,
progress_bar_refresh_rate=0,
# todo: enabled since internally we wrap the model for optimizer step, this should be fixed
enable_pl_optimizer=True
)

# no call yet
Expand Down