Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Dec 18, 2020

What does this PR do?

TODO: change the destination branch to master

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #5182 (8bb74cd) into bugfix/5165_enable_pl_optimizer (85e4e96) will decrease coverage by 61%.
The diff coverage is n/a.

@@                        Coverage Diff                        @@
##           bugfix/5165_enable_pl_optimizer   #5182     +/-   ##
=================================================================
- Coverage                               93%     32%    -61%     
=================================================================
  Files                                  134     134             
  Lines                                 9931    9793    -138     
=================================================================
- Hits                                  9245    3149   -6096     
- Misses                                 686    6644   +5958     

@Borda Borda changed the base branch from bugfix/5165_enable_pl_optimizer to bugfix/5165_enable_pl_optimizer_refactor December 19, 2020 18:34
@Borda Borda marked this pull request as ready for review December 19, 2020 18:34
@Borda
Copy link
Collaborator Author

Borda commented Dec 20, 2020

closing in favor of #5191

@Borda Borda closed this Dec 20, 2020
@Borda Borda deleted the bugfix/accumulated_grad_batches branch December 20, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant