Trainer.test should return only test metrics #5214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
Borda,
SeanNaren,
awaelchli,
justusschock and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5214 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 134 134
Lines 9945 9950 +5
======================================
+ Hits 9259 9261 +2
- Misses 686 689 +3 |
Borda
reviewed
Dec 21, 2020
SeanNaren
approved these changes
Dec 23, 2020
Borda
approved these changes
Dec 28, 2020
Borda
pushed a commit
that referenced
this pull request
Jan 6, 2021
* resolve bug * merge tests (cherry picked from commit 9ebbfec)
asnorkin
pushed a commit
to asnorkin/pytorch-lightning
that referenced
this pull request
Jan 15, 2021
* resolve bug * merge tests
asnorkin
pushed a commit
to asnorkin/pytorch-lightning
that referenced
this pull request
Feb 8, 2021
* resolve bug * merge tests
asnorkin
pushed a commit
to asnorkin/pytorch-lightning
that referenced
this pull request
Feb 9, 2021
* resolve bug * merge tests
asnorkin
pushed a commit
to asnorkin/pytorch-lightning
that referenced
this pull request
Feb 16, 2021
* resolve bug * merge tests
asnorkin
pushed a commit
to asnorkin/pytorch-lightning
that referenced
this pull request
Feb 17, 2021
* resolve bug * merge tests
rohitgr7
added a commit
that referenced
this pull request
Feb 22, 2021
* Trainer.test should return only test metrics (#5214) * resolve bug * merge tests * Fix metric state reset (#5273) * Fix metric state reset * Fix test * Improve formatting Co-authored-by: Ananya Harsh Jha <ananya@pytorchlightning.ai> * print() method added to ProgressBar * printing alongside progress bar added to LightningModule.print() * LightningModule.print() method documentation updated * ProgressBarBase.print() stub added * stub * add progress bar tests * fix isort * Progress Callback fixes * test_metric.py duplicate DummyList removed * PEP and isort fixes * CHANGELOG updated * test_progress_bar_print win linesep fix * test_progress_bar.py remove whitespaces * Update CHANGELOG.md Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Tadej Svetina <tadej.svetina@gmail.com> Co-authored-by: Ananya Harsh Jha <ananya@pytorchlightning.ai> Co-authored-by: Alexander Snorkin <Alexander.Snorkin@acronis.com> Co-authored-by: rohitgr7 <rohitgr1998@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5213
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃