Add LambdaCallback #5347

marload · 2021-01-04T12:20:09Z

What does this PR do?

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes [if needed]?
Did you write any new necessary tests [no need for typos, docs]?
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified
Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

marload · 2021-01-04T12:32:03Z

@tchaton

tchaton

Great work ! Could you update the raise error by providing a better message.
Can you make sure it works with all callback functions (auto-generate them and assert they are being called)

pytorch_lightning/callbacks/lambda_cb.py

codecov · 2021-01-04T13:02:31Z

Codecov Report

Merging #5347 (7ed3eea) into release/1.2-dev (dfbb592) will increase coverage by 0%.
The diff coverage is 94%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5347    +/-   ##
================================================
  Coverage               93%     93%            
================================================
  Files                  146     152     +6     
  Lines                10315   10824   +509     
================================================
+ Hits                  9549   10044   +495     
- Misses                 766     780    +14

SkafteNicki · 2021-01-04T13:08:59Z

@marload could you please rebase on the release/1.2-dev branch as this PR right now contains a lot of changes from master

# Conflicts: # CHANGELOG.md

Borda · 2021-01-04T13:19:39Z

Would you mind creating this PR from release/1.2-dev branch which is the feature branch ?

@marload I have fixed it so no action needed
cc: @tchaton @SkafteNicki

pytorch_lightning/callbacks/lambda_cb.py

Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

tests/callbacks/test_lambda_cb.py

marload · 2021-01-08T10:25:32Z

I should test the on_keyboard_interrrup and on_load_checkpoint hooks, but i dont know what to do. Who can help me?

tchaton · 2021-01-09T18:03:41Z

Hey @marload ,

You have 1 test failing. Can you resolve it ?

pep8speaks · 2021-01-09T19:40:57Z

Hello @marload! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-13 09:03:01 UTC

rohitgr7

@marload on_load_checkpoint was a bit tricky since to trigger that it requires on_save_checkpoint to return something. So tried something. Mind check?

tests/callbacks/test_lambda_cb.py

rohitgr7

again, can you please rename the files? else LGTM.

docs/source/callbacks.rst

* Add LambdaCallback * docs * add pr link # Conflicts: # CHANGELOG.md * convention * Fix Callback Typo * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> * use Misconfigureation * update docs * sort export * use inspect * string fill * use fast dev run * isort * remove unused import * sort * hilightning * highlighting * highlighting * remove debug log * eq * res * results * add misconfig exception test * use pytest raises * fix * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * hc * rm pt * fix * try fix * whitespace * new hook * add raise * fix * remove unused * rename Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz> Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: chaton <thomas@grid.ai>

marload requested review from awaelchli, Borda, edenlightning, justusschock, SeanNaren, tchaton and williamFalcon as code owners January 4, 2021 12:20

marload changed the title ~~Feature/lambdacallback~~ Add LambdaCallback Jan 4, 2021

tchaton reviewed Jan 4, 2021

View reviewed changes

pytorch_lightning/callbacks/lambda_cb.py Outdated Show resolved Hide resolved

tchaton changed the base branch from master to release/1.2-dev January 4, 2021 13:02

tchaton requested review from ananyahjha93 and teddykoker as code owners January 4, 2021 13:02

tchaton changed the base branch from release/1.2-dev to master January 4, 2021 13:09

marload and others added 5 commits January 4, 2021 14:09

Add LambdaCallback

0df6bd9

docs

aa13ddf

add pr link

01bd0a5

# Conflicts: # CHANGELOG.md

convention

b0953dd

Fix Callback Typo

7863e67

Borda force-pushed the feature/lambdacallback branch from 1a1ea36 to 7863e67 Compare January 4, 2021 13:14

Borda changed the base branch from master to release/1.2-dev January 4, 2021 13:17

Borda added this to the 1.2 milestone Jan 4, 2021

Borda added the feature Is an improvement or enhancement label Jan 4, 2021

Lightning-AI deleted a comment from tchaton Jan 4, 2021

SkafteNicki reviewed Jan 4, 2021

View reviewed changes

pytorch_lightning/callbacks/lambda_cb.py Outdated Show resolved Hide resolved

pytorch_lightning/callbacks/lambda_cb.py Outdated Show resolved Hide resolved

pytorch_lightning/callbacks/lambda_cb.py Outdated Show resolved Hide resolved

justusschock reviewed Jan 4, 2021

View reviewed changes

pytorch_lightning/callbacks/lambda_cb.py Outdated Show resolved Hide resolved

Update pytorch_lightning/callbacks/lambda_cb.py

6792408

Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

Borda and others added 5 commits January 6, 2021 01:25

Apply suggestions from code review

7293115

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Update pytorch_lightning/callbacks/lambda_cb.py

4d85f59

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

hc

c9ecb8a

rm pt

2044291

Merge branch 'release/1.2-dev' into feature/lambdacallback

5359ce6

tchaton reviewed Jan 6, 2021

View reviewed changes

tests/callbacks/test_lambda_cb.py Outdated Show resolved Hide resolved

fix

556ea09

tchaton approved these changes Jan 9, 2021

View reviewed changes

rohitgr7 added 2 commits January 10, 2021 01:07

try fix

d190e15

Merge branch 'release/1.2-dev' into feature/lambdacallback

d7bfc4a

rohitgr7 added 2 commits January 10, 2021 01:13

whitespace

a27dbff

new hook

d1bd19a

rohitgr7 reviewed Jan 9, 2021

View reviewed changes

tests/callbacks/test_lambda_cb.py Outdated Show resolved Hide resolved

marload added 3 commits January 10, 2021 14:44

add raise

afe018a

fix

709fb5b

remove unused

9b93a2c

rohitgr7 approved these changes Jan 10, 2021

View reviewed changes

docs/source/callbacks.rst Show resolved Hide resolved

justusschock approved these changes Jan 11, 2021

View reviewed changes

SkafteNicki approved these changes Jan 11, 2021

View reviewed changes

rename

72f3f0c

awaelchli approved these changes Jan 12, 2021

View reviewed changes

SkafteNicki enabled auto-merge (squash) January 12, 2021 12:58

SkafteNicki added 2 commits January 12, 2021 13:58

Merge branch 'release/1.2-dev' into feature/lambdacallback

7ed3eea

Merge branch 'release/1.2-dev' into feature/lambdacallback

2ce0131

SkafteNicki merged commit 61f415f into Lightning-AI:release/1.2-dev Jan 13, 2021

marload deleted the feature/lambdacallback branch January 14, 2021 00:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add LambdaCallback #5347

Add LambdaCallback #5347

marload commented Jan 4, 2021 •

edited by Borda

Loading

marload commented Jan 4, 2021

tchaton left a comment

codecov bot commented Jan 4, 2021 •

edited

Loading

SkafteNicki commented Jan 4, 2021

Borda commented Jan 4, 2021 •

edited

Loading

marload commented Jan 8, 2021

tchaton commented Jan 9, 2021 •

edited

Loading

pep8speaks commented Jan 9, 2021 •

edited

Loading

rohitgr7 left a comment

rohitgr7 left a comment

Add LambdaCallback #5347

Add LambdaCallback #5347

Conversation

marload commented Jan 4, 2021 • edited by Borda Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

marload commented Jan 4, 2021

tchaton left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 4, 2021 • edited Loading

Codecov Report

SkafteNicki commented Jan 4, 2021

Borda commented Jan 4, 2021 • edited Loading

marload commented Jan 8, 2021

tchaton commented Jan 9, 2021 • edited Loading

pep8speaks commented Jan 9, 2021 • edited Loading

Comment last updated at 2021-01-13 09:03:01 UTC

rohitgr7 left a comment

Choose a reason for hiding this comment

rohitgr7 left a comment

Choose a reason for hiding this comment

marload commented Jan 4, 2021 •

edited by Borda

Loading

codecov bot commented Jan 4, 2021 •

edited

Loading

Borda commented Jan 4, 2021 •

edited

Loading

tchaton commented Jan 9, 2021 •

edited

Loading

pep8speaks commented Jan 9, 2021 •

edited

Loading