Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug in testing for IterableDataset #547

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

MikeScarp
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements) (sort of, see below)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs? (not applicable here)
  • Did you write any new necessary tests? (not applicable)

What does this PR do?

Not a top level issue, but fixes comments raised in #231 and #405 and came up in #323 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@MikeScarp MikeScarp mentioned this pull request Nov 26, 2019
@williamFalcon
Copy link
Contributor

@MikeScarp thanks for the quick fix!

@williamFalcon williamFalcon merged commit 55f3ffd into Lightning-AI:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants