fix reinit_schedulers with correct optimizer #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
force-pushed
the
bugfix/reinit_scheds
branch
from
d2225be
to
115de5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5519 +/- ##
======================================
Coverage 93% 93%
======================================
Files 135 135
Lines 10006 10007 +1
======================================
+ Hits 9329 9341 +12
+ Misses 677 666 -11 |
rohitgr7
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
rohitgr7
changed the title
awaelchli
approved these changes
Jan 15, 2021
SkafteNicki
approved these changes
Jan 15, 2021
awaelchli
added a commit
to awaelchli/pytorch-lightning
that referenced
this pull request
Jan 24, 2021
this is a cherry pick from master
awaelchli
added a commit
to awaelchli/pytorch-lightning
that referenced
this pull request
Jan 24, 2021
fix x x x model test undo dp add todo fix reinit_schedulers with correct optimizer (Lightning-AI#5519) this is a cherry pick from master boring model lr try x forward call
12 tasks
Borda
pushed a commit
that referenced
this pull request
Feb 4, 2021
* update test * syntax * fix * update test * scheduler * only apex * fix * rev drone * chlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When schedulers are reinitialized while using apex, all of them are initialized with the last optimizer in
trainer.optimizers. Updated the test which fails on master.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃