Skip to content

Conversation

@Ir1d
Copy link
Contributor

@Ir1d Ir1d commented Dec 3, 2019

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #518 (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not remove logging

@Ir1d
Copy link
Contributor Author

Ir1d commented Dec 4, 2019

I was thinking that prepending a newline seems to be a good idea (suggested by @awaelchli )
@jeffling what do you think about this?
I moved the config to init @Borda . Thx!

@williamFalcon williamFalcon merged commit c316173 into Lightning-AI:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

versions after .5.2.1 do not print weights summary

5 participants