-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Fix some bugs for TPU [skip ci] #5878
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
6c993c5
fixed for single tpu
lezwon 18cee2a
fixed spawn
lezwon ec4636f
Merge branch 'accelerator-refactor-sharded' into accelerator-refactor…
tchaton 027a151
fixed spawn
lezwon 4f711e0
update
2d72415
update
a642b26
wip
5677ee7
Merge branch 'accelerator-refactor-sharded' into tpu_fix
tchaton 1cff0a9
resolve bugs
tchaton 369de6c
resolve bug
tchaton f4797aa
update on comment
tchaton 7395e03
removed decorator
tchaton 0b7aa2f
resolve comments
tchaton 9355e40
set to 4
tchaton 8a4925f
update
5f14189
update
69dafb6
need cleaning
b046ec5
update
e0dadda
update
tchaton 0472b9d
update
tchaton 5b3a381
resolve flake8
tchaton 843667f
resolve bugs
be5711f
exclude broadcast
3927d39
resolve bugs
1ed9d26
change test
f7bf098
update
c2bc888
update
4c50ef3
skip if meet fails
24be82a
Merge branch 'accelerator-refactor-sharded' into tpu_fix
tchaton 68474b7
properly raise trace
253ea99
Merge branch 'tpu_fix' of https://github.com/PyTorchLightning/pytorch…
aea078c
update
e092c64
add catch
a631273
wrap test
5e6a6a1
resolve typo
ffe820c
update
c250faa
typo
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was just a temporary fix. I think
TPUSpawnPlugin
is meant to be called above withinelif self.use_ddp
block.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep both for now.